Skip to content

[INS-469] Added Rev detectors to defaults.go and gated it behind feature flag#5005

Merged
MuneebUllahKhan222 merged 3 commits into
mainfrom
rev-detector
Jun 11, 2026
Merged

[INS-469] Added Rev detectors to defaults.go and gated it behind feature flag#5005
MuneebUllahKhan222 merged 3 commits into
mainfrom
rev-detector

Conversation

@MuneebUllahKhan222

@MuneebUllahKhan222 MuneebUllahKhan222 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Description:

This PR adds the existing Rev detector to defaults.go and ensures it is gated behind the appropriate feature flag.

Additionally, the PR updates the assertions in the existing integration tests to account for the changes made to the detector.Result struct.

Corpora Test:

The detector doesn't appear in the list.
image

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Note

Medium Risk
Turning on a new default detector can change scan findings and verification traffic; rollout is mitigated by the same feature-flag pattern as other recently enabled detectors.

Overview
Enables the existing Rev (transcription API) detector in the default engine by registering rev.Scanner in buildDetectorList(), wiring RevDetectorEnabled in pkg/feature, turning it on in OSS main.go with the other gated detectors, and filtering the scanner out when the flag is off.

The Rev detector now populates SecretParts with both key and client (multi-part credential). Integration tests were updated to compare results with go-cmp, ignoring newer detectors.Result fields. defaults_test moves DetectorType_Rev from the “never added” exclude list into the feature-flag-gated group. go.mod drops two unused indirect modules after tidy.

Reviewed by Cursor Bugbot for commit fa45b11. Bugbot is set up for automated code reviews on this repo. Configure here.

@MuneebUllahKhan222 MuneebUllahKhan222 requested a review from a team June 2, 2026 07:34
@MuneebUllahKhan222 MuneebUllahKhan222 requested review from a team as code owners June 2, 2026 07:34
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Corpora Test Results

No detector regex or keyword changes in this PR. Bench skipped.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7a56052. Configure here.

Comment thread pkg/detectors/rev/rev_integration_test.go Outdated
@MuneebUllahKhan222 MuneebUllahKhan222 merged commit ac0805e into main Jun 11, 2026
16 checks passed
@MuneebUllahKhan222 MuneebUllahKhan222 deleted the rev-detector branch June 11, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants