Restructure Klaviyo detector pattern tests#5026
Merged
Merged
Conversation
Rewrite the single table-driven pattern test as one focused test per case, and add the coverage the tightened regex needs. * Legacy lowercase-hex and the newer prefixed company_id format each get their own positive test. * New negatives: uppercase-hex body, a legacy body one char short, and a new-format hex tail one char long. * Inline each test's input and assertions; drop the shared fixture block. Co-authored-by: Cursor <cursoragent@cursor.com>
Corpora Test ResultsNo detector regex or keyword changes in this PR. Bench skipped. |
mariduv
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[authored by Cursor]
Summary
This is test-only; no production/detector code changes. It backs the tightened
keyPat(pk_+ 34 lowercase hex, orpk_+ 6 alnum company_id +_+ 34 hex) that landed in #5009.Test plan
go test ./pkg/detectors/klaviyo/passes (new suite,CGO_ENABLED=0)go vet+gofmt -lclean;go build ./...cleanMade with Cursor