fix(gltf) determine supported textures by web.gl from parse-gltf#3423
Open
nishalshettigar wants to merge 2 commits into
Open
fix(gltf) determine supported textures by web.gl from parse-gltf#3423nishalshettigar wants to merge 2 commits into
nishalshettigar wants to merge 2 commits into
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, the determination of supported textures was done from
parse-gltf.tsfile. The code in this file runs on the main thread. After the removal, this operation is happening fromparse-basis.tsfile. Since, the code in this file is run from a worker threads, it doesn't have access to the webgl context. Hence, it is not able to get the list of textures and this causes the rgb565 texture (the fallback texture) to be selected, instead of the supported compressed texture.Fixes visgl/deck.gl#9912