Intro RFC More Option Selectors#591
Open
waciumawanjohi wants to merge 2 commits into
Open
Conversation
|
✔️ Deploy Preview for elated-stonebraker-105904 canceled. 🔨 Explore the source changes: 8575656 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/62017efc30e8a00007083325 |
waciumawanjohi
force-pushed
the
rfc-more-option-selectors
branch
from
bc42f90 to
bda2fef
Compare
scothis
reviewed
Feb 7, 2022
squeedee
reviewed
Feb 7, 2022
| # Motivation | ||
| [motivation]: #motivation | ||
|
|
||
| Users may find the MatchLabels syntax simpler than the MatchFields syntax. |
Contributor
There was a problem hiding this comment.
Suggested change
| Users may find the MatchLabels syntax simpler than the MatchFields syntax. | |
| Users may find the MatchLabels syntax simpler than the MatchFields syntax. MatchLabels is a standard across all k8s objects that have selectors, and MatchExpressions is implemented for Pods and Jobs, meaning these selectors might be more familiar to users. |
Contributor
There was a problem hiding this comment.
Both label and field selectors are widely used across k8s, but typically not combined into a single "selector". I broadly agree that because labels are fields, for this purpose a label selector may seem like syntactic sugar on top of a more generic field selector, but the historical uses are quite different.
squeedee
approved these changes
Feb 7, 2022
martyspiewak
approved these changes
Feb 22, 2022
squeedee
approved these changes
Feb 22, 2022
jwntrs
approved these changes
Feb 25, 2022
sclevine
approved these changes
Feb 25, 2022
cirocosta
approved these changes
Feb 25, 2022
emmjohnson
approved these changes
Feb 28, 2022
idoru
approved these changes
Feb 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
Introduces RFC: More Option Selectors
Readable
Release Note
PR Checklist
Note: Please do not remove items. Mark items as done
[x]or usestrikethroughif you believe they are not relevant[ ] Linked to a relevant issue. Eg:Fixes #123orUpdates #123wipcommits[ ] Filled in the Release Note section above[ ] Modified the docs to match changes