fix: strip trailing blanks at printAbove consumer (#194)#195
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Review Summary by QodoMove stripTrailing to printAbove consumer for robust blank line removal
WalkthroughsDescription• Move stripTrailing() from producers to consumer boundary • Eliminates trailing blank lines in printAbove output • Defensive fix covers all producers with single change • Simplifies maintenance by centralizing strip logic Diagramflowchart LR
A["Multiple Producers<br/>cron/deferred/background"] -->|"text with trailing newlines"| B["pendingPrintAbove<br/>Consumer Loop"]
B -->|"stripTrailing()<br/>before split"| C["Split into lines"]
C -->|"clean lines"| D["printAbove calls"]
File Changes1. aceclaw-cli/src/main/java/dev/aceclaw/cli/TerminalRepl.java
|
Code Review by Qodo
1. stripTrailing drops trailing spaces
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe TerminalRepl's UI renderer now strips trailing whitespace using Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Owner
Author
Response to review feedbackQodo Bug #1:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text.stripTrailing()at thependingPrintAboveconsumer loop beforesplit("\n", -1)Why PR #186 wasn't enough
PR #186 added
stripTrailing()at each producer site, but:split("\n", -1)preserves trailing empty strings from any residual\nprintAbove("")→ visible blank lineThe correct fix is a single defensive strip at the consumer boundary.
Change
One line, covers all producers.
Closes #194
Summary by CodeRabbit