Skip to content

feat(skill): generate runtime skills within active sessions #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xinhuagu merged 10 commits into from
Mar 13, 2026
Merged

feat(skill): generate runtime skills within active sessions #219

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3af968e
feat(skill): generate runtime skills within active sessions
Mar 13, 2026
1948caf
fix(skill): harden dynamic runtime skill isolation
Mar 13, 2026
862fa53
Merge branch 'main' into codex/issue-132-dynamic-skill-generator
github-actions[bot] Mar 13, 2026
d8300a8
fix(skill): track dynamic runtime generation lifecycle
Mar 13, 2026
0ec1790
fix(skill): preserve runtime state until draft flush succeeds
Mar 13, 2026
90bde10
Merge branch 'main' into codex/issue-132-dynamic-skill-generator
github-actions[bot] Mar 13, 2026
d219006
fix(skill): tighten runtime draft generation semantics
Mar 13, 2026
40bc735
fix(skill): stabilize runtime skill prompt assembly
Mar 13, 2026
3a5f1de
fix(skill): harden runtime skill post-processing
Mar 13, 2026
dd80a8e
fix(skill): keep runtime generation independent of memory store
Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(skill): stabilize runtime skill prompt assembly
  • Loading branch information
Xinhua Gu committed Mar 13, 2026
commit 40bc7358ad629ac69201061ad57e3d8cda3987ab
8 changes: 6 additions & 2 deletions aceclaw-core/src/main/java/dev/aceclaw/core/agent/SkillRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ public List<String> names(String sessionId) {
if (sessionId != null && !sessionId.isBlank()) {
var runtime = runtimeRegistry.get(sessionId);
if (runtime != null && !runtime.isEmpty()) {
names.addAll(runtime.keySet());
runtime.keySet().stream()
.sorted()
.forEach(names::add);
}
}
return List.copyOf(names);
Expand All @@ -162,7 +164,9 @@ public List<SkillConfig> all(String sessionId) {
if (sessionId != null && !sessionId.isBlank()) {
var runtime = runtimeRegistry.get(sessionId);
if (runtime != null && !runtime.isEmpty()) {
runtime.forEach(combined::put);
runtime.entrySet().stream()
.sorted(Map.Entry.comparingByKey())
.forEach(entry -> combined.put(entry.getKey(), entry.getValue()));
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
return List.copyOf(combined.values());
Expand Down
6 changes: 5 additions & 1 deletion aceclaw-daemon/src/main/java/dev/aceclaw/daemon/StreamingAgentHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,11 @@ public void setContextAssemblyConfig(MarkdownMemoryStore markdownStore,
this.registeredToolNames = registeredToolNames != null ? Set.copyOf(registeredToolNames) : Set.of();
this.hasBraveApiKey = hasBraveApiKey;
this.skillDescriptionsProvider = skillDescriptionsProvider != null
? skillDescriptionsProvider : ignored -> "";
? sessionId -> {
var descriptions = skillDescriptionsProvider.apply(sessionId);
return descriptions != null ? descriptions : "";
}
: ignored -> "";
}

/**
Expand Down
Loading