Skip to content

ci: add observational platform-full jobs for macOS and Windows#379

Merged
xinhuagu merged 1 commit into
mainfrom
feat/370-step7b-platform-full
Mar 29, 2026
Merged

ci: add observational platform-full jobs for macOS and Windows#379
xinhuagu merged 1 commit into
mainfrom
feat/370-step7b-platform-full

Conversation

@xinhuagu

Copy link
Copy Markdown
Owner

Step 7b of #370: Full platform test coverage (observational)

New jobs

Job Platform Scope Required?
platform-full (macos-latest) macOS All modules, all tests (except replay/benchmark) No — continue-on-error: true
platform-full (windows-latest) Windows All modules except daemon, all tests (except replay/benchmark) No — continue-on-error: true

Why observational

These jobs surface platform-specific regressions without blocking PRs. Once the failure list is empty and stable, Step 7c will promote them to required.

Known limitations

  • Windows: :aceclaw-daemon:test excluded (Gradle worker JVM crash with AF_UNIX class scanning)
  • macOS: All tests included, but timing-sensitive tests may flake

What to watch

After this merges, check the first run to catalog which tests fail on each platform — that becomes the backlog for Step 7c.

New platform-full job runs broader test suites on macOS and Windows:
- macOS: full build + all tests except replay/benchmark
- Windows: full build + all tests except daemon module and replay/benchmark

Set continue-on-error: true — failures are visible but do not block PRs.
This is observational (Step 7b) to surface platform debt before promoting
to required (Step 7c).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai

coderabbitai Bot commented Mar 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .github/workflows/ci.yml is excluded by !.github/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ff4b8491-70e1-4b4e-962d-1225f773f589

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/370-step7b-platform-full

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhuagu xinhuagu merged commit 864ed09 into main Mar 29, 2026
8 of 9 checks passed
@xinhuagu xinhuagu deleted the feat/370-step7b-platform-full branch March 29, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant