fix: fall back to Redfish session token auth in baremetal agent#24995
Open
mvanhorn wants to merge 1 commit into
Open
fix: fall back to Redfish session token auth in baremetal agent#24995mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The baremetal agent's Redfish client now falls back to Session-token (
X-Auth-Token) authentication when Basic Auth is rejected, so Redfish endpoints that require session auth work instead of failing the probe.Why this matters
Some Redfish/BMC implementations reject Basic Auth and require a session token (#24911). The client only tried Basic Auth, so those endpoints failed. This reuses the existing
Login/SessionTokenmachinery inpkg/util/redfish/redfish.go: when the initial probe returns an authentication error (401/403), it logs in for a session token and retries. Non-auth failures (404/500) fast-fail as before and never create an unnecessary session, detected viaerrors.Ason the wrappedJSONClientErrorrather than a type assertion througherrors.Cause.This covers the authentication half of the issue; the non-standard System ID navigation path is already handled by the existing index-based Members traversal.
Testing
Loginand retries; 404 and 500 do not fall back and create no session.go buildandgo testpass forpkg/util/redfish.Refs #24911