scripts: genpinctrl: handle pins with analog switch#151
Conversation
gmarull
force-pushed
the
fix-analog-switch-handling
branch
from
dc468fd to
62cceec
Compare
GeorgeCGV
left a comment
GeorgeCGV
left a comment
There was a problem hiding this comment.
LGTM
ps: thanks, that was quick
This patch adds support for handling pins with analog switch (found in H7 series). This feature was removed in a previous patch because it was generating duplicate nodes. However, it removed some valid combinations. This patch adds them back but with proper suffix (_c) avoiding duplicate entries. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
Regenerate files so that pins with analog switch are present. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
gmarull
force-pushed
the
fix-analog-switch-handling
branch
from
62cceec to
ac8814e
Compare
| slew-rate = "very-high-speed"; | ||
| }; | ||
|
|
||
| /omit-if-no-ref/ octospim_p1_io2_pc2_c: octospim_p1_io2_pc2_c { |
There was a problem hiding this comment.
Sorry, but I'm not sure to follow. If these nodes are not duplicate. Why do they need to be disambiguated ?
There was a problem hiding this comment.
I was wondering the same but then realized that the the pin name in the device datasheet is actually called PC2_C so I guess this makes sense.
There was a problem hiding this comment.
I was wondering the same but then realized that the the pin name in the device datasheet is actually called PC2_C so I guess this makes sense.
yep, that's the point. previous file were actually wrong to my understanding.
There was a problem hiding this comment.
Ok, then this will require an update in release note.
4 participants
This patch adds support for handling pins with analog switch (found in
H7 series). This feature was removed in a previous patch because it was
generating duplicate nodes. However, it removed some valid combinations.
This patch adds them back but with proper suffix (_c) avoiding duplicate
entries.