feat: support default network interface binding and persist SSL certificate paths#3612
Open
arjo129 wants to merge 1 commit into
Open
feat: support default network interface binding and persist SSL certificate paths#3612arjo129 wants to merge 1 commit into
arjo129 wants to merge 1 commit into
Conversation
…ficate paths Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
iche033
reviewed
May 27, 2026
| /// | ||
| /// * `<port>` : An integer that is websocket port. | ||
| /// | ||
| /// * `<address>` or `<iface>` : A string that specifies the network |
Contributor
There was a problem hiding this comment.
checking if we actually need to introduce 2 new parameters or if we could just have one, e.g. <address> and just document that here that it also means iface - given that they both get parsed and stored in the same variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #
Summary
Split out from #3590, this PR changes the WebSocket server's default listening address from 0.0.0.0 to 127.0.0.1 (localhost).
Binding to 0.0.0.0 exposes the server to all network interfaces, opening the door to remote exploits like the one detailed in #3589. Restricting the default to 127.0.0.1 ensures a "secure by default" posture, limiting access to local traffic only.
Streamlined Review: Isolating this from #3590 allows us to land this critical security hardening measure immediately without it being blocked by broader feature work.
Backport Recommendation: Breaks behaviour, don't backport
Ive also bundled in some lifetime related fixes.
Test it
Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.