Update some tests to be independent of entity ordering (backport #3592)#3642
Open
mergify[bot] wants to merge 1 commit into
Open
Update some tests to be independent of entity ordering (backport #3592)#3642mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Update the most straightforward tests to make them independent of order of entity in Each. Both tests check that a query contains all the entities that should be present (i.e. a world has all the required models, model all the required links, link all the required collisions / visuals). However, it expects them to be in a specific order that is more of an implementation detail. This PR, span out of the entt refactor, updates the tests so they still validate that all the entities are present but don't test anymore that they are iterated in a specific order. Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove potential endless loop in SdfGenerator test Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * SimulationRunner entity order independence Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> --------- Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Co-authored-by: Arjo Chakravarty <arjoc@intrinsic.ai> (cherry picked from commit 12219ac) # Conflicts: # src/SdfEntityCreator_TEST.cc # src/SimulationRunner_TEST.cc
Contributor
Author
|
Cherry-pick of 12219ac has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Span out of #3447
Summary
Update the most straightforward tests to make them independent of order of entity in Each.
Both tests check that a query contains all the entities that should be present (i.e. a world has all the required models, model all the required links, link all the required collisions / visuals). However, it expects them to be in a specific order that is more of an implementation detail.
This PR, span out of the entt refactor, updates the tests so they still validate that all the entities are present but don't test anymore that they are iterated in a specific order.
Test it
Tested by CI, or run the affected tests manually
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #3592 done by Mergify.