Prepare wanted-search tests and CI for normalization work by mjc · Pull Request #3383 · morpheus65535/bazarr

mjc · 2026-06-11T16:30:03Z

Summary

This PR adds the backend test foundation needed to safely change wanted-search behavior in follow-up PRs.

The main goal is to make wanted movie/episode searches, language parsing, profile handling, and database interactions testable with realistic rows instead of broad monkeypatching. Later PRs in this stack use this harness to harden existing paths and then move wanted-search state out of serialized columns.

What changed

Added transactional SQLAlchemy test fixtures backed by isolated in-memory SQLite databases.
Added shared wanted-search table fixtures and row factories for movie, episode, subtitle, history, profile, and failed-attempt scenarios.
Added shared language helpers for parsing wanted subtitle tokens, normalizing forced/HI flags, resolving audio-language data, building provider search payloads, and formatting episode display values.
Added pytest import/path setup so Bazarr modules can be imported consistently in backend tests.
Added dependency floors needed by the backend test/import path.
Updated CI so backend tests, frontend checks, Python compatibility, and the app smoke test run from the same workflow surface.
Reworked the app smoke script to wait for the UI to become responsive instead of relying on a fixed sleep.

Why this is separate

The wanted-search normalization work is easier to review if the reusable fixtures and baseline behavior tests land first. This PR intentionally keeps the storage model unchanged and focuses on testability, shared helpers, and CI reliability.

Follow-up PRs build on this layer for wanted search, mass download, provider/subtitles API paths, manual upload/download paths, sync/profile parsing, upgrade paths, and finally normalized wanted-search storage.

Tests

The added tests cover the shared language helper behavior, malformed wanted-language input, profile flag normalization, missing scene-name handling, transactional rollback isolation, and the wanted-search fixture layer itself. CI changes also exercise the backend test suite, frontend checks, and app smoke startup path from the consolidated workflow.

Align requests floor with vendored runtime

Add shared wanted-search fixture layer Cover wanted-search fixtures with focused tests

mjc · 2026-06-11T16:54:38Z

+done

-exit ${exitcode}
+echo "UI is responsive."


functionality of this script should be the same, it was just not very robust before.

mjc · 2026-06-11T16:56:57Z

@@ -1,102 +1,199 @@
 name: CI
+# Touch this file to keep GitHub Actions registered on the default branch.


the CI overhaul is removable but it seemed prudent to be able to trigger the tests on CI so I gave the CI a full poke.

Caching, hardening against the recent GitHub actions exploits, etc.

it might be worth checking if the build tools should be replaced with faster ones, to save on CI compute time.

and I'd recommend requiring maintainer intervention before allowing CI to run on a PR

mjc · 2026-06-11T16:58:13Z

@@ -1,57 +0,0 @@
-name: test_bazarr_execution


this was originally just renamed but I guess they diverged too far and git forgot

mjc · 2026-06-11T17:01:17Z

@@ -0,0 +1,45 @@
+from sqlalchemy import select
+
+def test_movie_row_factory_inserts_rows(


we do not need to actually test these if we don't want to. but I needed an example to verify everything works in this pr.

mjc · 2026-06-11T17:02:34Z

+import subtitles.language_utils as language_utils
+
+
+def test_parse_language_token_canonicalizes_case_and_flag_order():


this and the language_utils.py are part of tests and bug fixes in the follow-on PRs. I pulled language utils out because it was a good self-contained example of a unit test to verify it runs etc.

also the follow-ons are kinda long and I'm trying not to have too-giant PRs.

The code that this replaces in the follow-on PRs was buggy enough to warrant this kind of "pull it out and refactor it" anyway, but if doing that made it harder to review I'm happy to help clean up however is convenient.

mjc · 2026-06-11T17:03:47Z

+requests>=2.33.0
+PyYAML>=6.0.3
+whichcraft>=0.6.1
+dogpile.cache>=1.5.0


all of these were not specified but are used in the code, so I found my first bug directly in the harness I guess

Those requirements are vendored in libs directory and listed in libs/version.txt

I'm not super familiar with the current state of python tooling (sqlalchemy was pretty new when I last did high-perf python), but basically everything I tried didn't notice that.

I can back that out if you'd rather.

out of curiosity why is any of it vendored at all? feels like an unusual category of app to care about supply chain resistance that much.

mjc · 2026-06-11T18:54:06Z

noticing I have more stuff to pull into this branch from my other branches so it's draft for now

(cherry picked from commit faa01ff) test: add mass-download fixture support test: complete mass-download fixture support test: add shared wanted database binder test: simplify wanted kind inference test: register wanted fixtures at top level test: drop unused transactional tmp fixture test: bind profile lookup to wanted test database test: bind profile list lookup to wanted fixtures

mjc · 2026-06-14T17:12:53Z

perf work is still coming, just haven't had time to get it into shape yet. mjc#1 if you want an early look.

mjc · 2026-06-15T19:38:53Z

I moved a few more shared test/setup pieces into this PR so the follow-up wanted-search work can keep building on the same fixture layer.

This adds:

test bootstrap defaults needed for importing Bazarr under pytest
parse_known_args() in app.get_args so pytest/runner flags do not break imports
wanted-search fixture updates that use the real movie/show/episode table names
fixture helpers for seeding legacy missing_subtitles and failedAttempts values from normal Python sequences

The wanted-search behavior coverage that depends on this fixture layer now lives in the follow-up wanted/adaptive PR.

mjc added 2 commits June 10, 2026 12:42

Add missing runtime dependency floors

f3132f0

Align requests floor with vendored runtime

Build transactional SQLAlchemy test harness

838d15a

Add shared wanted-search fixture layer Cover wanted-search fixtures with focused tests

mjc commented Jun 11, 2026

View reviewed changes

mjc marked this pull request as draft June 11, 2026 18:53

mjc added 2 commits June 11, 2026 12:54

Update CI workflow and build_test script

f65376e

mjc force-pushed the mjc/wanted-search-tests branch from c22ff12 to 4de4f95 Compare June 11, 2026 18:55

mjc mentioned this pull request Jun 11, 2026

Harden wanted-search language behavior for normalization work #3384

Open

mjc added 2 commits June 11, 2026 13:16

Move shared language helpers into PR 3

76f8597

Reject unknown language flags

a012bd2

mjc force-pushed the mjc/wanted-search-tests branch from 4de4f95 to a012bd2 Compare June 11, 2026 19:16

mjc added 2 commits June 11, 2026 23:47

Normalize language profile flags

16c0b62

Normalize scene-name plumbing

ebf1b42

mjc added 2 commits June 14, 2026 11:28

ci: pin pytest below 9

9d65fad

tests: make app bootstrap test friendly

fcb2867

tests: improve wanted search fixtures

735e9cf

mjc force-pushed the mjc/wanted-search-tests branch from 1493a84 to 735e9cf Compare June 15, 2026 19:44

mjc marked this pull request as ready for review June 19, 2026 18:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare wanted-search tests and CI for normalization work#3383

Prepare wanted-search tests and CI for normalization work#3383
mjc wants to merge 11 commits into
morpheus65535:developmentfrom
mjc:mjc/wanted-search-tests

mjc commented Jun 11, 2026 •

edited

Loading

Uh oh!

mjc Jun 11, 2026 •

edited

Loading

Uh oh!

mjc Jun 11, 2026 •

edited

Loading

Uh oh!

mjc Jun 11, 2026

Uh oh!

mjc Jun 11, 2026

Uh oh!

mjc Jun 11, 2026 •

edited

Loading

Uh oh!

mjc Jun 11, 2026

Uh oh!

morpheus65535 Jun 12, 2026

Uh oh!

mjc Jun 12, 2026

Uh oh!

mjc commented Jun 11, 2026

Uh oh!

mjc commented Jun 14, 2026

Uh oh!

mjc commented Jun 15, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,102 +1,199 @@
		name: CI
		# Touch this file to keep GitHub Actions registered on the default branch.

		@@ -0,0 +1,45 @@
		from sqlalchemy import select

		def test_movie_row_factory_inserts_rows(

		import subtitles.language_utils as language_utils


		def test_parse_language_token_canonicalizes_case_and_flag_order():

Conversation

mjc commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Why this is separate

Tests

Uh oh!

mjc Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjc Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjc Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

mjc Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

mjc Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjc Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

morpheus65535 Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

mjc Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

mjc commented Jun 11, 2026

Uh oh!

mjc commented Jun 14, 2026

Uh oh!

mjc commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mjc commented Jun 11, 2026 •

edited

Loading

mjc Jun 11, 2026 •

edited

Loading

mjc Jun 11, 2026 •

edited

Loading

mjc Jun 11, 2026 •

edited

Loading

mjc commented Jun 15, 2026 •

edited

Loading