drop width from the protocol spec#1649
Open
raphamorim wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the
widthparameter from therverb (introduced in v1.7).A registration cannot override its codepoint's cell width: registered glyphs are always one cell, matching the codepoint's
wcwidth/ UAX #11 width (1for every PUA codepoint). Cell width is not the terminal's alone to decide, interactive applications (shells/line editors, TUIs, multiplexers) independently compute column counts with their ownwcwidth, and a terminal-only width override is invisible to them, so a declared-wide glyph desyncs the cursor between terminal and application.We could potentially fix this later but frankly is better to rely on wcwidth now to don't break tools.
If you really want to have two cells icons, you can have a glyph registered plus a space (this is will be settled up by your side) + rely on baseline rasterizer that scales to the font size rasterize_payload, it gets
pixel_size = size_u16 (the font size in px). It will for any tool that useswcwidth.