Avoid blocking the event loop with requests.get in async update_model_type#5055
Open
kratos0718 wants to merge 1 commit into
Open
Conversation
…_type update_model_type is an async actor method, but it called the synchronous requests.get() directly, which blocks the actor's event loop for up to the 30s timeout while downloading model configurations from the remote API. During that window the worker cannot service any other request. Run the blocking call in a thread via asyncio.to_thread(), matching the pattern already used throughout this module.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates xinference/core/worker.py to run the blocking requests.get call inside asyncio.to_thread when downloading JSON from a remote API. This prevents the synchronous network request from freezing the actor's event loop. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
update_model_typeis anasyncactor method, but it calls the synchronousrequests.get(url, timeout=30)directly:A blocking call inside a coroutine freezes the actor's event loop for the entire duration of the request — up to the 30s timeout while downloading model configurations from
model.xinference.io. During that window the worker actor cannot service any other request.Fix
Run the blocking request in a worker thread with
asyncio.to_thread(), so the event loop stays responsive:This matches the pattern already used throughout
worker.py(e.g.await asyncio.to_thread(...)appears in several other places in this module).asynciois already imported at the top of the file. No behavior change other than no longer blocking the loop.