Skip to content

Avoid blocking the event loop with requests.get in async update_model_type #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kratos0718 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Avoid blocking the event loop with requests.get in async update_model_type #5055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions xinference/core/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,8 +1396,9 @@ async def update_model_type(self, model_type: str):
)

try:
# Download JSON from remote API
response = requests.get(url, timeout=30)
# Download JSON from remote API. Run the blocking request in a
# worker thread so it does not freeze the actor's event loop.
response = await asyncio.to_thread(requests.get, url, timeout=30)
response.raise_for_status()

# Parse JSON response
Expand Down