HAL_ChibiOS: Add Lectron Pi5 and V6X board definitions#33423
Open
lectronuser wants to merge 3 commits into
Open
HAL_ChibiOS: Add Lectron Pi5 and V6X board definitions#33423lectronuser wants to merge 3 commits into
lectronuser wants to merge 3 commits into
Conversation
0413155 to
3c644c2
Compare
0f90f98 to
ab79d37
Compare
peterbarker
requested changes
Jun 16, 2026
peterbarker
left a comment
Contributor
There was a problem hiding this comment.
CI must pass
Glancing review only.
Comment on lines
+1
to
+9
| ATC_RAT_PIT_D,0.0019 | ||
| ATC_RAT_PIT_I,0.049 | ||
| ATC_RAT_PIT_P,0.049 | ||
| ATC_RAT_RLL_D,0.0014 | ||
| ATC_RAT_RLL_I,0.037 | ||
| ATC_RAT_RLL_P,0.037 | ||
| ATC_RAT_YAW_D,0.0005 | ||
| ATC_RAT_YAW_I,0.026 | ||
| ATC_RAT_YAW_P,0.263 |
Contributor
There was a problem hiding this comment.
These don't make sense for a generic autopilot.
Contributor
|
@lectronuser commit structure is wrong...one commit per library....commit name begins with library: |
Contributor
|
Automated hwdef review ( PR 33423 · base Build
Must-fix
Should-fix
Notes
Generated by Claude via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New boards (Lectron Pi5 Autopilot and Lectron V6x ) have been added to the system.
Classification & Testing (check all that apply and add your own)
Description
Context